[FFL-1319] Add feature flags events exposure #5024

Strech · 2025-11-05T16:26:49Z

What does this PR do?

Adds new component under lib/datadog/open_feature/ folder that is providing customer an ability to configure Datadog feature flags provider. This provider is going to rely on Remote Configuration to deliver feature flags configurations (aka UFC Universal Flag Configuration).

Said provider is going into customer code as a part of configuration for OpenFeature

require 'open_feature/sdk'
require 'datadog/open_feature/provider'

Datadog.configure do |config|
  config.open_feature.enabled = true
end

OpenFeature::SDK.configure do |config|
  config.set_provider(Datadog::OpenFeature::Provider.new)
end

client = OpenFeature::SDK.build_client
client.fetch_string_value(flag_key: 'banner', default_value: 'default')
# => 'something-for-that-context'

Motivation:

This is a part of upcoming work across all libs.

Important

This code doesn't contain actual evaluation logic, but rather establish everything for it to be placed in the next PR.

Change log entry

No. Will be announced in another PR

Additional Notes:

This PR was already reviewed as a part of #5022, but accidentally was marked as ready for review. This code is fresh and already applied some suggestions from the previous review, but not everything is possible due to the existing established way or the time boundaries.

Structure:

lib/datadog/open_feature
├── binding <------- A pre-made place for upcoming binding (written in Ruby)
├── exposures <----- Every time we fetch the flag value we are sending exposure event
├── provider.rb <--- A public API class we expose (see example above)
└── transport <----- Implementation that goes along with existing components

I would like to ask some pair of eyes on thread-safety and potential issues of new component. I've run the code over certain checks already, but never enough.

How to test the change?

CI and we will have new set of ST in #5022 enabled to prove that everything works.

github-actions · 2025-11-05T16:27:03Z

Thank you for updating Change log entry section 👏

^{Visited at: 2025-11-11 09:56:41 UTC}

pr-commenter · 2025-11-05T16:58:25Z

Benchmarks

Benchmark execution time: 2025-11-13 11:20:27

Comparing candidate commit e572afc in PR branch ffl-1319-add-agent-communication-for-openfeature with baseline commit e4ed440 in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics.

scenario:error - error tracking, with_error=true - third_party only

🟥 throughput [-660.099op/s; -577.527op/s] or [-5.881%; -5.146%]

scenario:profiling - Allocations ()

🟥 throughput [-260821.824op/s; -230695.621op/s] or [-7.897%; -6.985%]

scenario:profiling - stack collector (varying depth)

🟩 throughput [+56.667op/s; +57.451op/s] or [+6.302%; +6.389%]

github-actions · 2025-11-10T13:10:22Z

Typing analysis

Note: Ignored files are excluded from the next sections.

Untyped methods

This PR introduces 2 untyped methods and 5 partially typed methods. It increases the percentage of typed methods from 53.12% to 54.7% (+1.58%).

Untyped methods (+2-0)

❌ Introduced:

sig/datadog/open_feature/provider.rbs:8
└── def initialize: () -> void
sig/datadog/open_feature/transport/http/api.rbs:8
└── def self?.defaults: () -> untyped

Partially typed methods (+5-0)

❌ Introduced:

sig/datadog/open_feature/configuration.rbs:12
└── def self.add_settings!: (untyped base) -> void
sig/datadog/open_feature/exposures/event.rbs:33
└── def self.extract_attributes: (::OpenFeature::SDK::EvaluationContext) -> ::Hash[::String, untyped]
sig/datadog/open_feature/exposures/worker.rbs:48
└── def perform: (*untyped) -> void
sig/datadog/open_feature/transport/exposures.rbs:14
└── def initialize: (OpenFeature::Transport::Exposures::EncodedParcel, ?::Hash[::Symbol, untyped]?) -> void
sig/datadog/open_feature/transport/exposures.rbs:28
└── def send_exposures: (::Hash[::Symbol, untyped], ?headers: ::Hash[::Symbol, untyped]?) -> Core::Transport::Response

Untyped other declarations

This PR introduces 1 untyped other declaration and 3 partially typed other declarations. It increases the percentage of typed other declarations from 66.95% to 68.02% (+1.07%).

Untyped other declarations (+1-0)

❌ Introduced:

sig/datadog/open_feature/resolution_details.rbs:4
└── attr_accessor value: untyped

Partially typed other declarations (+3-0)

❌ Introduced:

sig/datadog/open_feature/resolution_details.rbs:14
└── attr_accessor flag_metadata: ::Hash[::String, untyped]?
sig/datadog/open_feature/resolution_details.rbs:18
└── attr_accessor extra_logging: ::Hash[::String, untyped]?
sig/datadog/open_feature/transport/exposures.rbs:12
└── attr_reader headers: ::Hash[::Symbol, untyped]

If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept to the end of the line to remove it from the stats.

datadog-datadog-prod-us1 · 2025-11-10T13:16:16Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
• Patch Coverage: 94.44%
• Total Coverage: 98.51% (-0.03%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: e572afc | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

lib/datadog/core/configuration/components.rb

lib/datadog/open_feature/provider.rb

appraisal/ruby-3.4.rb

lib/datadog/open_feature/binding/evaluator.rb

lib/datadog/open_feature/exposures/models/event.rb

lib/datadog/open_feature/exposures/deduplicator.rb

lib/datadog/open_feature/binding/resolution_details.rb

lib/datadog/open_feature/exposures/reporter.rb

lib/datadog/open_feature/exposures/worker.rb

lib/datadog/open_feature/transport/http/api.rb

lib/datadog/open_feature/transport/http/client.rb

lib/datadog/open_feature/transport/http/exposures.rb

lib/datadog/open_feature/binding.rb

lib/datadog/open_feature/component.rb

lib/datadog/open_feature/evaluation_engine.rb

lib/datadog/open_feature/exposures.rb

lib/datadog/open_feature/provider.rb

lib/datadog/open_feature/remote.rb

lib/datadog/core/remote/client/capabilities.rb

ivoanjo

Left a few notes!

lib/datadog/core/remote/client/capabilities.rb

lib/datadog/open_feature/component.rb

lib/datadog/open_feature/configuration/settings.rb

lib/datadog/open_feature/binding.rb

lib/datadog/open_feature/exposures/batch_builder.rb

lib/datadog/open_feature/exposures/buffer.rb

lib/datadog/open_feature/exposures/worker.rb

Co-authored-by: Ivo Anjo <[email protected]>

Co-authored-by: Sameeran Kunche <[email protected]>

Co-authored-by: Ivo Anjo <[email protected]>

* Improve performance of the hot-paths * Add error handling in remote configuration * Complete shutdown process

github-actions bot added core Involves Datadog core libraries appsec Application Security monitoring product labels Nov 5, 2025

Strech force-pushed the ffl-1319-add-agent-communication-for-openfeature branch from dbc899c to 0a25c37 Compare November 6, 2025 11:44

sameerank mentioned this pull request Nov 7, 2025

[FFL-1361] Evaluation in binding in ruby #5022

Draft

Strech force-pushed the ffl-1319-add-agent-communication-for-openfeature branch 3 times, most recently from b1a978f to 9e7efb0 Compare November 10, 2025 10:02

github-actions bot added integrations Involves tracing integrations profiling Involves Datadog profiling tracing labels Nov 10, 2025

Strech changed the base branch from add-openfeature-component to master November 10, 2025 12:42

Strech force-pushed the ffl-1319-add-agent-communication-for-openfeature branch from d7424f9 to 2221c34 Compare November 10, 2025 15:04

sameerank reviewed Nov 10, 2025

View reviewed changes

lib/datadog/core/configuration/components.rb Outdated Show resolved Hide resolved

sameerank reviewed Nov 11, 2025

View reviewed changes

lib/datadog/open_feature/provider.rb Outdated Show resolved Hide resolved

Strech marked this pull request as ready for review November 11, 2025 10:09

Strech requested a review from a team as a code owner November 11, 2025 10:09

Strech added the openfeature A new component that provider an ability to configure feature flags label Nov 11, 2025

y9v reviewed Nov 11, 2025

View reviewed changes

lib/datadog/open_feature/exposures/worker.rb Outdated Show resolved Hide resolved

y9v reviewed Nov 11, 2025

View reviewed changes

lib/datadog/open_feature/transport/http/api.rb Show resolved Hide resolved

y9v reviewed Nov 11, 2025

View reviewed changes

Strech commented Nov 11, 2025

View reviewed changes

lib/datadog/core/remote/client/capabilities.rb Show resolved Hide resolved

y9v approved these changes Nov 11, 2025

View reviewed changes

ivoanjo removed the profiling Involves Datadog profiling label Nov 11, 2025

y9v removed the appsec Application Security monitoring product label Nov 11, 2025

ivoanjo reviewed Nov 11, 2025

View reviewed changes

Strech and others added 24 commits November 13, 2025 11:12

Fix standardrb complaints

f39e6aa

Fix duplication issue in components

ea0776a

Fix loading specs

62e6a0e

Remove stale types

e814c6a

Add additional test case for RC being disabled

7b3d536

Add missing RBS definitions

1ba10f1

Apply suggested changes from the review

a4a3ffb

Update lib/datadog/open_feature/component.rb

e2a6bd6

Co-authored-by: Ivo Anjo <[email protected]>

Reduce boilerplate and unnecessary files

fdc8975

Fix worker flushing on demand and shutdown

e2ea13a

Remove unnecessary methods from batch builder

bf101c6

Add helper methods to the resolution details

057168c

Remove unused evaluation engine exposed methods

ed55b41

Fix issues raised by standardrb

ca515b4

Update provider documentation

d0212d8

Update spec/datadog/open_feature/remote_spec.rb

0fcbd14

Co-authored-by: Sameeran Kunche <[email protected]>

Update lib/datadog/open_feature/component.rb

cf7425e

Co-authored-by: Ivo Anjo <[email protected]>

Update lib/datadog/open_feature/exposures/worker.rb

8420179

Co-authored-by: Ivo Anjo <[email protected]>

Update lib/datadog/open_feature/evaluation_engine.rb

0ab7091

Co-authored-by: Ivo Anjo <[email protected]>

Update lib/datadog/open_feature/exposures/reporter.rb

fe83a47

Co-authored-by: Ivo Anjo <[email protected]>

Update lib/datadog/open_feature/exposures/event.rb

b375017

Co-authored-by: Ivo Anjo <[email protected]>

Update lib/datadog/open_feature/exposures/worker.rb

6025613

Co-authored-by: Ivo Anjo <[email protected]>

Update lib/datadog/open_feature/transport/exposures.rb

6609310

Co-authored-by: Ivo Anjo <[email protected]>

Update lib/datadog/open_feature/transport/http/exposures.rb

db96bdf

Co-authored-by: Ivo Anjo <[email protected]>

Strech force-pushed the ffl-1319-add-agent-communication-for-openfeature branch from 511d86e to 14b676f Compare November 13, 2025 10:13

Fix edge-cases mentioned in review

e572afc

* Improve performance of the hot-paths * Add error handling in remote configuration * Complete shutdown process

Strech force-pushed the ffl-1319-add-agent-communication-for-openfeature branch from 14b676f to e572afc Compare November 13, 2025 10:51

Strech merged commit 38d2bd9 into master Nov 13, 2025
566 checks passed

Strech deleted the ffl-1319-add-agent-communication-for-openfeature branch November 13, 2025 16:27

github-actions bot added this to the 2.23.0 milestone Nov 13, 2025

[FFL-1319] Add feature flags events exposure #5024

[FFL-1319] Add feature flags events exposure #5024

Conversation

Strech commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

scenario:error - error tracking, with_error=true - third_party only

scenario:profiling - Allocations ()

scenario:profiling - stack collector (varying depth)

Uh oh!

github-actions bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Typing analysis

Untyped methods

Untyped other declarations

Uh oh!

datadog-datadog-prod-us1 bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ivoanjo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Strech commented Nov 5, 2025 •

edited

Loading

github-actions bot commented Nov 5, 2025 •

edited

Loading

pr-commenter bot commented Nov 5, 2025 •

edited

Loading

github-actions bot commented Nov 10, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Nov 10, 2025 •

edited

Loading